Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nickname input field and validation #191

Merged
merged 2 commits into from
Jan 28, 2025
Merged

fix: nickname input field and validation #191

merged 2 commits into from
Jan 28, 2025

Conversation

Shivam25092001
Copy link
Contributor

FIXED

  • Card's nickname validation flow in Add-Payment-Method flow using $0 payments.

CHANGED

  • Nickname input field to accept max length of 12 characters. User input's length is restricted rather than throwing them length related validation error.

NOTE

@manideepk90 to remove nickNameLengthExceedError locale string from remote storage.

@aashu331998 aashu331998 merged commit e1d7256 into main Jan 28, 2025
5 checks passed
@aashu331998 aashu331998 deleted the fix-nickname-validation branch January 28, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashu331998 aashu331998 Awaiting requested review from aashu331998

@sh-iv-am sh-iv-am Awaiting requested review from sh-iv-am

@manideepk90 manideepk90 Awaiting requested review from manideepk90

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shivam25092001 @aashu331998