-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): add duplication_check
field in stored card response
#59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NishantJoshi00
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, looks good!
…tarus into add-duplication-check
…tarus into add-duplication-check
NishantJoshi00
approved these changes
Dec 14, 2023
Chethan-rao
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to add
duplication_check
field in stored card response. This field can have three values (duplicated
,meta_data_changed
andnull
).duplicated
: indicates that the entire card details in the card request is already present in the locker.meta_data_changed
: indicates that there is already a saved card with same card number but with different card details (like cvv, expiry or card holder name).null
: indicates that is not present in the locker.Test Case :-
-> Add a new card
-> Try to add a card which is already present
-> Try to add a card which is already present but this time with updated card data (except card number)
Tested the change with hyperswitch main for backwards compatibility
-> create payment method
-> list customer
-> payment create with saved card