Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Set as Wallpaper' option for KDE #711

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rudraksh88
Copy link

Added an option to set the current image as wallpaper for KDE Plasma.

@jurplel
Copy link
Owner

jurplel commented Oct 12, 2024

Couple of notes:

  • The blast radius of this PR is very large—I think there may have been an issue basing the changes off of our current master.
  • There should probably be a compile-time option to disable linking with dbus and this feature, or it should at least be enabled only on linux
    • An effect of that is that we might want to try to move this new KDE-specific code somewhere more isolated—the codebase is littered with ifdef like unexploded ordinance
  • Are environment variables sufficient to determine if we are running KDE? Has it been investigated if checking for running processes is a more durable/practical solution (genuinely not sure)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants