Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings #675

Closed
wants to merge 197 commits into from
Closed

Fix deprecation warnings #675

wants to merge 197 commits into from

Conversation

MaykGyver
Copy link
Contributor

The build workflow yields warnings:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/upload-artifact@v3.

This pr updates:

  • actions/checkout@v3 → actions/checkout@v4
  • actions/upload-artifact@v3 → actions/upload-artifact@v4

QA:

  • warnings vanish
  • build runs without complaints
  • tested the executable on win64 successfully

jdpurcell and others added 30 commits December 3, 2022 15:15
@jdpurcell
Fix CI build and preloading.
b7e93d9
@jdpurcell
CI: Fix nightly version in About dialog.
740b5b1
@jdpurcell
Improve scroll to zoom experience with high resolution touchpads
210358b
@jdpurcell
Optimizations for listing files in directory.
b7b6155
@jdpurcell
Skip updating directory file listing during rapid image switching.
a58796a
@jdpurcell
Partial workaround for slow Open With menu updating on Mac.
7714981
@jdpurcell
Workaround for slow Open Recent menu on Mac.
3e43470
@jdpurcell
Window matches image size when launching: Fix glitch with maximized w…
68e7148 
…indows.
@jdpurcell
Fix double rotation bug when loading cached image.
e947671
@jdpurcell
Basic color space support.
4f2ded4
@jdpurcell
macOS: Fix disappearing application menu items.
48aaf53
@jdpurcell
File navigation improvements: Better handling of deleted files, and s…
50d7371 
…upports opening a folder directly.
@jdpurcell
Options to constrain image within viewport area.
795810a
@jdpurcell
Customize build name.
15172d3
@jdpurcell
* CI: Fix nightly version in About dialog (for non-Windows too this t…
d7790ff 
…ime).
@jdpurcell
Fix constrained positioning with mirrored/flipped image.
22499f6
@jdpurcell
Massive cleanup of scale/transform code
26d5c56
@jdpurcell
Show zoom level in title bar in practical and verbose modes.
a76aa4a
@jdpurcell
Fix zooming towards cursor when window isn't focused
7a77093
@jdpurcell
Scrolling animation code cleanup.
1d89f91
@jdpurcell
Ad-hoc sign mac app
9414f1e
@jdpurcell
Fix image positioning when switching images with fancy scaling enabled
6c805e2
@jdpurcell
Copy GitHub Actions implementation from upstream
3d90efb
@jdpurcell
Customize nightly build number
5eee57e
@jurplel @jdpurcell
Fix open with dialog not working on Linux
d6cff7d
@jurplel @jdpurcell
Fix qView appearing in open with menu on linux after desktop file nam…
f4698e6 
…e change
@jdpurcell
Fix missing items in File -> Open With menu
fa97f55
@jdpurcell
Fix regression with "window matches image size"
3731de6
@jdpurcell
Fix "Recent" list getting randomly reset
7b4d0d8
@jdpurcell
Revert "Partial workaround for slow Open With menu updating on Mac."
a8a731a 
This reverts commit 7714981.
jdpurcell and others added 26 commits October 9, 2023 23:13
@jdpurcell
Disable titlebar hiding on legacy macOS
170bba5 
It doesn't work right
@jdpurcell
Windows: Fix "Show in Explorer" with long paths even if 8.3 names are…
fccc653 
… disabled.
@jdpurcell
Rework UI for settings categories
2af2576
@jdpurcell
Remove workaround in mouse settings UI
6eafa4d 
I had manually set some widgets to be hidden in the designer to work around sizing issues, but this isn't needed now that they're in a scroll area.
@jdpurcell
Adjust form field growth policy and alignment
c044e20 
Already the default for macOS; this makes other platforms behave similarly.
@jdpurcell
Adjust margins and spacing
4915ea4
@jdpurcell
Padding adjustment
24842d3
@jdpurcell
Remove old tooltips
2bb3329
@jdpurcell
Ability to disable loading certain file extensions.
1b26365
@jdpurcell
Release prep
1540ff0
@apfelchips @jdpurcell
Ignore macOS ._ metadata files
75a10be
@jdpurcell
Display error message inside viewport instead of as a modal dialog
819d75c 
Thanks to @fkubicek for some of the ideas that made this possible
@jdpurcell
Fix shortcut editor not reflecting unsaved value
2d04c5b
@jdpurcell
Update copyright year
26d2032
@jdpurcell
Release prep
f6cdbe1
@jdpurcell
Update OpenSSL
4234b21 
Qt 6.5 can only use OpenSSL 3.x. Networking was still working without it due to Schannel fallback. Not sure if any of the OpenSSL features are really needed but oh well.
@jdpurcell
Enforce position constraints when scrolling with PageUp and PageDown.
241f873
@jdpurcell
When file load is requested, take advantage of in-progress preloads i…
8820e0c 
…f possible
@jdpurcell
Navigate as quickly as possible/desired when holding down previous/ne…
1d0abd4 
…xt file shortcut keys
@jdpurcell
Release prep
9785567
@jdpurcell
Update confirmation dialog text for "delete permanently"
85e1734
@jdpurcell
Ensure icons are hidden in parentless menubar in macOS
27e4e34 
For Qt 6.7+, where QIcon::fromTheme now returns icons even on macOS. Ensures icons don't show in the menubar when all windows have been closed. And fixes performance issue caused by the icons.
@jdpurcell
New option in "zoom default" dropdown for "original size"
5ce1cff
@jdpurcell
Change "image resizes past actual size" option into configurable zoom…
8f08e91 
… limit percent
@jdpurcell
Settings UI: Improve alignment of a few checkboxes
4fe259b
@MaykGyver
actions/*@V3 → v4
e7b9fc4
@jdpurcell jdpurcell mentioned this pull request Apr 24, 2024
Merged
@jurplel
Copy link
Owner

jurplel commented May 6, 2024

It looks like this PR has a lot of changes—maybe it was rebased on something besides master?

@jdpurcell
Copy link
Contributor

Yeah it was based on my master, no worries though, this fix has already been merged because I cherry-picked @MaykGyver's commit into #666. Thanks for the contribution, @MaykGyver!

@jurplel jurplel closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaykGyver @jurplel @jdpurcell @apfelchips