macOS/Qt5: Fix HEIF #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ahh I think the vcpkg cache messed up the first run, let me try it without the cache. |
|
That worked. Are you fine with the commit to keep the cache disabled? I did that on my fork a while back, I think the cache is more trouble than it's worth. |
|
Makes sense to me. Thanks for catching this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for a regression introduced by last PR: HEIF wasn't working in the legacy Qt 5 macOS build. A few
brew uninstallcommands were removed because they resulted inError: No such kegon the newer macOS runners.zlibdoesn't seem to be present on 13 or 14 anymore. But I failed to noticewebpis only not present on 14, and still existing on 13. It didn't even cause any build errors, it just somehow(?!) resulted in the HEIF plugin being non-functional.