Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ui-tests #20

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Fix ui-tests #20

merged 1 commit into from
Jan 8, 2024

Conversation

martinRenou
Copy link
Member

There are no real UI-tests yet so let's make it dumb so that it's green for now

There are no real UI-tests yet so let's make it dumb so that it's green
@martinRenou martinRenou merged commit 22092e8 into jupyterlite:main Jan 8, 2024
6 of 7 checks passed
@martinRenou martinRenou deleted the fix_ui_tests branch January 8, 2024 15:47
@jtpio
Copy link
Member

jtpio commented Jan 8, 2024

Maybe the UI tests should be added to the kernel repos directly now?

Some UI tests might be generic, such as this one: jupyterlite/xeus-python-kernel#175

Others more specific to each kernel, for example: jupyterlite/xeus-python-kernel#187

@martinRenou
Copy link
Member Author

Maybe a tiny test here would be useful, maybe using a fake kernel if we can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants