Start the server awareness #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you need help with this (I see tests are failing). |
|
Yes, I took a look at the tests, it seems that The tests pass if we remove the error if the awareness is already started. This probably means that the awareness is not properly stopped, but I don't know how to fix it. |
davidbrochart
requested changes
Oct 14, 2024
| @@ -231,6 +231,7 @@ async def start( | |||
| self._task_group.start_soon(self._stopped.wait) | |||
| self._task_group.start_soon(self._watch_ready) | |||
| self._task_group.start_soon(self._broadcast_updates) | |||
| self._task_group.start_soon(self.awareness.start) | |||
There was a problem hiding this comment.
You need that above too, in the if from_context_manager: branch.
pycrdt_websocket/yroom.py
Outdated
| @@ -240,6 +241,7 @@ async def stop(self) -> None: | |||
| if self._task_group is None: | |||
| raise RuntimeError("YRoom not running") | |||
| self._stopped.set() | |||
| self.awareness.stop() | |||
There was a problem hiding this comment.
Suggested change
| self.awareness.stop() | |
| await self.awareness.stop() |
Co-authored-by: David Brochart <[email protected]>
|
Thanks @davidbrochart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR start the server awareness periodic update.
It follows jupyter-server/pycrdt#178.