-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show API summary #56
base: main
Are you sure you want to change the base?
Show API summary #56
Conversation
2ce73fe
to
57c2db2
Compare
842b7eb
to
41a3ed5
Compare
Thanks @davidbrochart ! I'll have a look |
@davidbrochart what about making |
We discussed that with @SylvainCorlay, but the point of this PR is making it mandatory to display the API, so that you don't allow e.g. websockets by mistake. |
Hey @davidbrochart sorry for the delay.. I would prefer to make this a dev extra dependency, maybe also move this to
I don't really get it, could you please expand a bit more? |
I support @adriendelsalle on this one. The goal is to have a plugin approach to be able to build the lighter server possible. So everything should be optional including the way we want to display output. For example log message are really important to be kept as such in deployed scenarios where admin sys usually aggregate them in monitoring third-party service. |
It can also be helpful to ensure there is no security risk, especially if you want to check if the websocket endpoints are served.
FPS could be have terminal UI, show a dashboard etc.
I think FPS being a TUI doesn't break the plugin approach, and it can still be lightweight.
We could also dump logs to a file. |
The main point here is separation of concern. FPS is (and should focus) on being a pluggable server. Any kind on UI should be a plugin or a separate beast. So why not placing this in a plugin. Indeed the current PR is not breaking it. But we should keep leverage the plugin system every time we can otherwise we will create yet another mammoth out of laziness. |
I agree with that. |
4cb22cf
to
de99a02
Compare
This last commit implements (the beginning of) a dashboard, as an FPS plugin. It currently only shows the API summary. |
42640e4
to
d6ec2f4
Compare
d6ec2f4
to
c9646e0
Compare
Actually I'm realizing that the dashboard doesn't need to be an FPS plugin. Maybe it should live in the jupyverse repository, since it will probably be specific to Jupyter. |
This PR now only consists of adding a |
@adriendelsalle OK to merge? |
Kindly pinging @adriendelsalle. |
See #55