Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Helm chart package #843

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Conversation

ljubon
Copy link
Collaborator

@ljubon ljubon commented Oct 10, 2023

Relates to #789

Description

The goal of this PR is to convert docker-compose.yml to a basic Helm 3 chart

Checklist

  • Add CI steps to support Helm 3 migration
  • Publish image jupyter/sparkmagic to ghcr.io
  • Publish image jupyter/sparkmagic-livy publishing to ghcr.io
  • Stay compatible with docker-compose.yml
  • Provide how-to steps
# Create local k8s cluster inside container
kind create cluster --name jupiter

# Install helm chart to container
helm install sparkmagic ./helm
OR
helm upgrade --install sparkmagic ./helm

@dosubot dosubot bot added the kind:enhancement A new Sparkmagic feature label Oct 10, 2023
@devstein devstein self-requested a review October 10, 2023 15:06
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljubon Thank you for doing this! It's a commonly requested feature.

I'll test it out locally later this week. I appreciate the detailed PR description.

helm/Chart.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@devstein devstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm locally, thanks for tackling this @ljubon!

@devstein devstein merged commit b284633 into jupyter-incubator:master Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:enhancement A new Sparkmagic feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants