Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passive thebe manager #756

Merged
merged 13 commits into from
Jul 15, 2024
Merged

passive thebe manager #756

merged 13 commits into from
Jul 15, 2024

Conversation

stevejpurves
Copy link
Collaborator

@stevejpurves stevejpurves commented Jul 14, 2024

This PR introduces a ThebePassiveManager to support hydration from widget state and takes steps to integrate that into thebe-react and demo-react

@stevejpurves stevejpurves marked this pull request as draft July 14, 2024 00:03
@stevejpurves stevejpurves changed the title wip wip - passive thebe manager Jul 14, 2024
Copy link
Contributor

github-actions bot commented Jul 14, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-15 05:04 UTC

@stevejpurves stevejpurves marked this pull request as ready for review July 14, 2024 22:49
@stevejpurves stevejpurves changed the title wip - passive thebe manager passive thebe manager Jul 14, 2024
@stevejpurves stevejpurves merged commit 30f569e into main Jul 15, 2024
3 checks passed
@stevejpurves stevejpurves deleted the feat/hydrate-widget-state branch July 15, 2024 05:00
stevejpurves added a commit that referenced this pull request Sep 5, 2024
stevejpurves added a commit that referenced this pull request Sep 5, 2024
* Revert "🛠️ fix/direct import bug (#757)"

This reverts commit 95eb9b5.

* Revert "passive thebe manager (#756)"

This reverts commit 30f569e.

* 📘 changeset
stevejpurves added a commit that referenced this pull request Sep 5, 2024
* wip

* latest

* controls are rendering

* revert notebookId change

* remove lumino

* use the rendermime

* 🎉 outputs

* fix markdown cell

* alert on comms change

* add factory method

* added on message handler

* 🧹 tidy up, upgrade demo

* 📗 changeset
stevejpurves added a commit that referenced this pull request Sep 5, 2024
* wip

* latest

* controls are rendering

* revert notebookId change

* remove lumino

* use the rendermime

* 🎉 outputs

* fix markdown cell

* alert on comms change

* add factory method

* added on message handler

* 🧹 tidy up, upgrade demo

* 📗 changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant