Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✊ update pyodide dependencies #751

Merged
merged 3 commits into from
Jun 11, 2024
Merged

✊ update pyodide dependencies #751

merged 3 commits into from
Jun 11, 2024

Conversation

stevejpurves
Copy link
Collaborator

fixes #750

@stevejpurves
Copy link
Collaborator Author

@jtpio I've been looking back into the pyodide-kernel repo and see that widgetsnbextensions is effectively a no-op/mock there? is that correct, why is it needed? is it because some JupyterLab (or other) code a automatically tries to load that extension when ipywidgets are in play. Would love to understand it more.

@stevejpurves stevejpurves merged commit a9a06ab into main Jun 11, 2024
4 checks passed
@stevejpurves stevejpurves deleted the fix/lite-widgets-issue branch June 11, 2024 13:01
@github-actions GitHub Actions
Copy link
Contributor

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-11 13:04 UTC

@jtpio
Copy link
Contributor

jtpio commented Jun 11, 2024

iirc, it's because widgetsnbextensions when installing ipywidgets on the fly in the notebook, for example with %pip install ipywidgets. With the dependency on widgetsnbextensions being defined here: https://github.com/jupyter-widgets/ipywidgets/blob/bb2edf78e7dac26e4b15522a267d7b477026a840/python/ipywidgets/setup.cfg#L40

stevejpurves added a commit that referenced this pull request Jun 11, 2024
@stevejpurves
✊ update pyodide dependencies (#751)
1eae7a1 
* ✊ update pyodide dependencies

* 🔧 fix PR preview

* 🔧 ci fix 2
@stevejpurves
Copy link
Collaborator Author

thanks @jtpio that makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thebe-lite fails to run
2 participants
@stevejpurves @jtpio