remediate wcag 2.1.2 - no keyboard trap #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
stevejpurves
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
@tonyfast thanks for the PR. I just tested a rebased version of this branch locally and it works as expected. Esc gets me out of context.
I don't think there is anything to change here, other than adding a changeset and linting which I'll just do on main as a release is imminent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hey y'all, i figured i'd kick off this discussion with a pull request instead of an issue. i'm proposing to add support for the Esc. currently, thebe violates Success Criterion 2.1.2 (No Keyboard Trap). this pull request applies technique G21: Ensuring that users are not trapped in content so that when
Escis pressed we usecm.display.input.blur()to remove focus from the editor allowing keyboard users to continue through their natural tab order.i'm not really great at js development or testing so i'd appreciate any pointers to cleaning up the pr.