🧹 Upgrade unified/unist stack #1603
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
agoose77
force-pushed
the
agoose77/chore-upgrade-unist-deps
branch
from
c119acb to
fbc1df8
Compare
|
🚀 |
agoose77
force-pushed
the
agoose77/chore-upgrade-unist-deps
branch
from
88515c0 to
28ceda5
Compare
agoose77
force-pushed
the
agoose77/chore-upgrade-unist-deps
branch
from
28ceda5 to
2dafdd2
Compare
As long as this function is top-level only, it's ok.
the spec will change soon anyway
rowanc1
reviewed
Nov 6, 2024
| @@ -140,6 +140,7 @@ export async function transformMystXRefs( | |||
| } else { | |||
| const data = await fetchMystXRefData(session, node as CrossReference, vfile); | |||
| if (!data) return; | |||
| console.debug({ identifier: node.identifier }); | |||
rowanc1
reviewed
Nov 6, 2024
| @@ -163,6 +162,7 @@ describe('Testing mdast --> html conversions', () => { | |||
| test.each(htmlCases)('%s', (name, { html, mdast }) => { | |||
| const modified = replaceCommentNodes(mdast); | |||
| if (html) { | |||
| console.log({ name, skip: SKIP_TESTS.some((p) => p.test(name.trim())) }); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts the process of upgrading our internals to use
unified@^11,@types/mdast@^4, and@types/unist@^3. We will need to make this change at some point, and given the nature of unifiedjs, this is a broad-reaching change.It massages our existing code to stop complaining about the
GenericParent <-> Nodedifferences that arise in@types/mdast@^4, and pulls in the latest version of the various unist utilities. This is mostly done by additions of type asserts (as XXX) that will need to be removed in future.Related to this work is jupyter-book/myst-spec#67, whereby the
myst-spectypes have been modified to use the extension mechanism supported by@types/mdast@>=4. After this PR in #1603 is merged, the integration of jupyter-book/myst-spec#67 should remove the need forGenericParentaltogether.To be clear, this PR is independent of jupyter-book/myst-spec#67
Note
We can't completely upgrade the stack: the unified-latex ecosystem is stuck on an older spec.
However, this is an internal tool, so we just need to ensure that it generates valid mdast@^4, and ignore any type errors. I think that it does from glancing at it.