Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤏 Improve theme for narrow screens #477

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Sep 24, 2024

This PR sets some flex styling to avoid shrinkage causing issues at intermediate widths.
This PR does not address the need to perhaps tweak the menu breakpoints / move the theme button into the ellipsis menu.

Existing:

  • Unnecessarily wide search bar
  • Stretched theme icon
  • Warped action button(s)

image

New:

  • Narrower search bar
  • Non-growing/shrinking (square) theme icon
  • Non-shrinking action button(s)

image

Copy link

changeset-bot bot commented Sep 24, 2024

🦋 Changeset detected

Latest commit: 767984b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@myst-theme/site Patch
@myst-theme/providers Patch
@myst-theme/frontmatter Patch
@myst-theme/diagrams Patch
@myst-theme/jupyter Patch
@myst-theme/styles Patch
@myst-theme/common Patch
@myst-theme/icons Patch
@myst-theme/search Patch
@myst-theme/search-minisearch Patch
@myst-theme/book Patch
@myst-theme/article Patch
myst-to-react Patch
myst-demo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rowanc1
Copy link
Collaborator

rowanc1 commented Sep 24, 2024

Can you put screenshots in?!

@agoose77 agoose77 force-pushed the agoose77/feat-theme-improvements-narrow branch from e808454 to 767984b Compare September 26, 2024 14:16
@stevejpurves
Copy link
Contributor

@agoose77 is wide screen behaviour unchanged? even when there are a good list of nav items in the topbar?

@agoose77
Copy link
Collaborator Author

@stevejpurves I've done some more testing on that, and I think it needs some work.

I think we need to start applying more conditional styling so that if users have nav items, we prefer compactness at intermediate sizes. Does anyone have any thoughts here? It's a bit of a feedback loop between nav and search at the moment.

@agoose77 agoose77 marked this pull request as draft October 2, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants