Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📌 run notebooks on the correct path #224

Merged
merged 6 commits into from
Aug 22, 2023
Merged

📌 run notebooks on the correct path #224

merged 6 commits into from
Aug 22, 2023

Conversation

stevejpurves
Copy link
Contributor

The location of a notebook relative to the project root folder is important and we assume that code in the notebook is written relative to the project root.

This change uses the location field exposed in jupyter-book/mystmd#564 and not properly passed to thebe using the kernelOptions.path in place of kernelOptions.name (see jupyter-book/thebe#677)

packages/jupyter/src/execute/provider.tsx Outdated Show resolved Hide resolved
packages/jupyter/src/execute/types.ts Outdated Show resolved Hide resolved
packages/jupyter/src/execute/leaf.tsx Show resolved Hide resolved
@stevejpurves stevejpurves merged commit e6c1ec8 into main Aug 22, 2023
2 checks passed
@stevejpurves stevejpurves deleted the feat/location branch August 22, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants