🏞 Fix placeholders when outputs are empty (#183)

jupyter-book · Jul 17, 2023 · 0b36379 · 0b36379
1 parent 88aa318
commit 0b36379
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/.changeset/beige-mice-attend.md b/.changeset/beige-mice-attend.md
@@ -0,0 +1,5 @@
+---
+'@myst-theme/jupyter': patch
+---
+
+Placeholders are now displayed in figures that embed notebook cells with empty outputs
diff --git a/packages/jupyter/src/output.tsx b/packages/jupyter/src/output.tsx
@@ -6,6 +6,8 @@ import { SafeOutputs } from './safe';
 import { JupyterOutputs } from './jupyter';
 import { useMemo } from 'react';
 import { useCellExecution } from './execute';
+import { usePlaceholder } from './decoration';
+import { MyST } from 'myst-to-react';
 
 export const DIRECT_OUTPUT_TYPES = new Set(['stream', 'error']);
 
@@ -51,9 +53,15 @@ export function JupyterOutput({
     () => allOutputsAreSafe(outputs, DIRECT_OUTPUT_TYPES, DIRECT_MIME_TYPES),
     [outputs],
   );
+  const placeholder = usePlaceholder();
 
   let component;
   if (allSafe && !ready) {
+    if (placeholder && (!outputs || outputs.length === 0)) {
+      if (placeholder) {
+        return <MyST ast={placeholder} />;
+      }
+    }
     component = <SafeOutputs keyStub={outputId} outputs={outputs} />;
   } else {
     component = <JupyterOutputs id={outputId} outputs={outputs} />;