Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: fix locale lang code name #1622

Merged
merged 1 commit into from
Jan 7, 2025
Merged

perf: fix locale lang code name #1622

merged 1 commit into from
Jan 7, 2025

Conversation

fit2bot
Copy link
Contributor

@fit2bot fit2bot commented Jan 7, 2025

perf: fix locale lang code name

@fit2bot fit2bot requested a review from a team January 7, 2025 02:23
@@ -26,6 +26,7 @@ var i18nCodeMap = map[string]LanguageCode{
"pt_br": PtBr,
"pt": PtBr,
"zh-cn": ZH,
"zh_cn": ZH,
"zh-hans": ZH,
"zh-hant": ZHHant,
"zh_hant": ZHHant,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code snippet appears to have minor inconsistencies. To check for discrepancies that might point towards potential issues or optimizations, I would ask for some more specific details about what aspects you want to examine:

  • Differences between zh and ZH, indicating which is intended (since both values seem identical).
  • Variations among different locales like pt_br and PtBr.
  • Inconsistencies involving zh, such as whether 'zh' is intended specifically for simplified Chinese (zh-CN) instead of 'ZHHant'.

With detailed feedback on these questions, I can help identify specific adjustments needed in the code, if necessary.

Remember, since this code seems quite specific to its original context within a larger project or document, it could be better suited for a technical discussion forum where actual coding practices are discussed without the need for strict adherence to current versions or standards.

Copy link

sonarqubecloud bot commented Jan 7, 2025

@LeeEirc LeeEirc merged commit f27a794 into dev Jan 7, 2025
6 of 7 checks passed
@LeeEirc LeeEirc deleted the pr@dev@perf_langcode branch January 7, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants