Perf: Change SFTP Connect Token #1617
Conversation
| @@ -42,7 +42,7 @@ const getFileManageUrl = () => { | |||
| let fileConnectionUrl: string = ''; | |||
|
|
|||
| if (routeName === 'Terminal') { | |||
| fileConnectionUrl = urlParams ? `${BASE_WS_URL}/koko/ws/sftp/?${urlParams.toString()}` : ''; | |||
| fileConnectionUrl = urlParams ? `${BASE_WS_URL}/koko/ws/sftp/?token=${urlParams.toString().split('&')[1].split('=')[1]}` : ''; | |||
|
|
|||
| return fileConnectionUrl; | |||
| } | |||
There was a problem hiding this comment.
I'm sorry, but there was an issue with the syntax of your code block. The code snippets you provided appear to be incomplete or incorrect. Could you please revise them? Additionally, I'm unable to verify any changes based on this context due to lack of source information about the current version of TypeScript and React used in these projects. Please provide more details or restructure it properly for better analysis and insights into potential irregularities or optimizations.
If you're asking whether there are any differences between the given two files (which seem to be JavaScript), here would be something similar:
// This is the first part before differences were made.
import useMessage from './useMessage'; // Assuming `useMessage` is not defined elsewhere.
import { type UploadFileInfo } from './naive-ui/dist';
...However, this still doesn't answer what discrepancies might exist because without further information on how the initial versions looked like at each line and across other lines, etc., my response cannot be correct.
Would you mind specifying where the two codes start/stop being compared so that we can analyze their content comprehensively? Thank you!
| @@ -203,8 +203,7 @@ const { t } = useI18n(); | |||
| const fileManageStore = useFileManageStore(); | |||
|
|
|||
| const isLoaded = ref(false); | |||
| // todo)) 还原为 false | |||
| const isShowList = ref(true); | |||
| const isShowList = ref(false); | |||
| const settingDrawer = ref(false); | |||
| const tabDefaultValue = ref('fileManage'); | |||
| const tableData = ref<RowData[]>([]); | |||
There was a problem hiding this comment.
This code does not seem to be an actual JavaScript code with specific context like files, components, modules etc. There can't be any regular checks or deviations from this piece of data on current date as stated.
There are some small changes I would suggest:
- Remove the
todo)comments at line 205 (since it doesn't refer back to a function/method). Comments should relate directly to how they impact functionality.
// Assuming there's something relevant here...
- If you're using React or TypeScript with functional components then instead of
<RowData...consider using props which makes sense for component interfaces since no implementation is mentioned for these components.
So just remove those commented-out lines and go ahead as planned, no need to make additional optimizations/changes per the original post content given here.
|
Perf: Change SFTP Connect Token