[Utilities] refactor promote_operation #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odow
changed the title
|
This is looking okay. I'll tackle the |
blegat
reviewed
Jun 13, 2023
blegat
reviewed
Jun 13, 2023
blegat
reviewed
Jun 13, 2023
Co-authored-by: Benoît Legat <[email protected]>
odow
force-pushed
the
od/promote-operation
branch
from
fe041e8 to
4833847
Compare
|
Merging because this is clearly a win |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the
Utilities.promote_operationmethods into a single file with tests.This is going to be a WIP until I settle on a nice design.