Makes the wrap type adapter factory single class #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| builder.registerTypeAdapterFactory(new WrapTypeAdapterFactory(wrappedClasses)); | ||
|
|
||
| for(Map.Entry<Class, Mapper> wrappedEntries: wrappedClasses.entrySet()) { | ||
| builder.registerTypeAdapterFactory(new WrapTypeAdapterFactory(wrappedEntries.getKey(), wrappedEntries.getValue())); |
There was a problem hiding this comment.
My only concern here is that if you register two wrappers, one for Animal and another one for Cat, you should be aware that it will wrap with the first registered. Apart from that, looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andressanchez please review this change to your pull request #27
I think it makes it more natural to the Gson standards and we dont need to do the loop to get the parent classes