Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase performance #30

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Increase performance #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da35e22
Try to speed up GH action logger
devmotion Jul 1, 2023
5a12635
Remove `format_props`
devmotion Jul 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 30 additions & 17 deletions src/GitHubActions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,38 +35,51 @@ struct MissingInputError <: Exception
end

Base.showerror(io::IO, e::MissingInputError) =
print(io, "Input required and not supplied: $(e.k)")
print(io, "Input required and not supplied: ", e.k)

cmd_value(::Nothing) = ""
cmd_value(s::AbstractString) = s
cmd_value(x) = json(x)

esc_data(::Nothing) = ""
function esc_data(val)
s = cmd_value(val)
s = replace(s, '%' => "%25")
s = replace(s, '\r' => "%0D")
s = replace(s, '\n' => "%0A")
if VERSION >= v"1.7"
s = replace(s, '%' => "%25", '\r' => "%0D", '\n' => "%0A")
else
s = replace(s, '%' => "%25")
s = replace(s, '\r' => "%0D")
s = replace(s, '\n' => "%0A")
end
return s
end

function esc_prop(val)
s = cmd_value(val)
s = replace(s, '%' => "%25")
s = replace(s, '\r' => "%0D")
s = replace(s, '\n' => "%0A")
s = replace(s, ':' => "%3A")
s = replace(s, ',' => "%2C")
if VERSION >= v"1.7"
s = replace(s, '%' => "%25", '\r' => "%0D", '\n' => "%0A", ':' => "%3A", ',' => "%2C")
else
s = replace(s, '%' => "%25")
s = replace(s, '\r' => "%0D")
s = replace(s, '\n' => "%0A")
s = replace(s, ':' => "%3A")
s = replace(s, ',' => "%2C")
end
return s
end

format_props(props) =
join(map(p -> string(p.first, "=", esc_prop(p.second)), collect(pairs(props))), ',')

function command(cmd, props, val)
s = CMD_MARKER * cmd
isempty(props) || (s *= ' ' * format_props(props))
s *= CMD_MARKER * esc_data(val)
println(s)
print(CMD_MARKER, cmd)
if !isempty(props) && (cmd == "notice" || cmd == "warning" || cmd == "error")
print(' ')
ps = pairs(props)
n = length(ps)
for (i, p) in enumerate(ps)
print(p.first, "=", esc_prop(p.second))
i < n && print(',')
end
end
println(CMD_MARKER, esc_data(val))
end

fail() = exit(1)
Expand All @@ -78,7 +91,7 @@ add_to_file(k, v) = open(f -> println(f, v), ENV[k], "a")

End a group that was started with [`start_group`](@ref).
"""
end_group() = command("endgroup", (), "")
end_group() = command("endgroup", (), nothing)

"""
get_state(k)
Expand Down