Merge pull request #20 from jukylin/fix_traceid_len

fix traceId length
jukylin · Jun 20, 2018 · ff801e9 · ff801e9
2 parents eed11b7 + 1477a22
commit ff801e9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Jaeger/Jaeger.php b/src/Jaeger/Jaeger.php
@@ -227,7 +227,7 @@ public function flush(){
 
 
     private function generateId(){
-        return microtime(true) * 10000 . rand(1000, 9999);
+        return microtime(true) * 10000 . rand(10000, 99999);
     }
 }
 

diff --git a/src/Jaeger/SpanContext.php b/src/Jaeger/SpanContext.php
@@ -76,9 +76,9 @@ public function isSampled(){
 
     public function traceIdToString($traceId){
         $len = strlen($traceId);
-        if($len > 15){
-            $this->traceIdHigh = hexdec(substr($traceId, 0, 15));
-            $this->traceIdLow = hexdec(substr($traceId, 15));
+        if($len > 16){
+            $this->traceIdHigh = hexdec(substr($traceId, 0, 16));
+            $this->traceIdLow = hexdec(substr($traceId, 16));
         }else{
             $this->traceIdLow = hexdec($traceId);
         }