fix(pylibjuju): restore + fix pylibjuju check merge jobs #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out in 2022[!] we accidentally removed the pylibjuju check merge jobs from juju-qa-jenkins. This went unnoticed since then, since `make push` does not remove job not in jjb IaC However, the job recently broke. To fix this: 1) The job had to be restored 2) A fix had to be implemented It turns out the job was broken in two ways: 1) We tried to install python 3.6 (ancient) on Noble, which failed 2) In the case a repo does not have a go.mod file, we incorrectly set GOVERSION to '' (i.e. a string containing two quote marks) instead of an empty string. This lead to failures later down the line
cderici
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out in 2022[!] we accidentally removed the pylibjuju check merge jobs from juju-qa-jenkins.
This went unnoticed since then, since
make pushdoes not remove job not in jjb IaCHowever, the job recently broke. To fix this:
It turns out the job was broken in two ways:
GOVERSION to '' (i.e. a string containing two quote marks) instead of
an empty string. This lead to failures later down the line
QA Steps
See successful merges in pylibjuju e.g.
juju/python-libjuju#1067