fix: GO111MODULE broken with go 1.22 update #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go no longer support go get outside of a module with the GO111MODULE enviromental var: https://tip.golang.org/doc/go1.22. Change the uses of this to go install instead. A version for the modules is required since it would normally use the go.mod one.
manadart
approved these changes
Jul 2, 2024
| builders: | ||
| - shell: |- | ||
| #!/bin/bash | ||
| set -eux | ||
| GO111MODULE=off go get {modules} | ||
| go install {modules} |
There was a problem hiding this comment.
This is the only one I don't know about. All those listed would have to include the specific version/latest.
There was a problem hiding this comment.
I've changed all the usages of this to be latest
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go no longer support go get outside of a module with the GO111MODULE environmental var: https://tip.golang.org/doc/go1.22. Change the uses of this to go install instead. A version for the modules is required since it would normally use the go.mod one.