setup: pin macaroonbakery<1.3.3 for python3.6 #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macaroonbakery in v1.3.4 added a constraint of protobuf>=3.20.0[0] which makes it incompatible with python 3.6 and v1.3.3 was released in a broken state[1].
|
I'm still having trouble with octavia/ussuri failing to build due to macaroonbakery/protobuf (https://review.opendev.org/c/openstack/charm-octavia/+/902746). It's only broken for Python3.6 (Bionic) which only effects ussuri, victoria is fine since it only needs Python3.8 (Focal). The specific issue is charm-tools < 3.0.0 -> libcharmstore -> theblues -> macaroonbakery charm-tools 3.x actually installs and works fine on python3.6 (and works to build the charm) because libcharmstore was dropped, but the stable charms currently tend to pin charm-tools to <3.0.0 (or == 2.8.x) |
coreycb
approved these changes
Jan 11, 2024
freyes
approved these changes
Jan 11, 2024
openstack-mirroring
pushed a commit
to openstack/charm-octavia
that referenced
this pull request
Mar 6, 2024
Switch to using the latest charm-tools <3.0.0 to fix three build errors: - An error related to 'pytz' fixed in charm-tools 2.8.6: juju/charm-tools#654 - An error related to ruamel.yaml fixed in charm-tools 2.8.8: here: juju/charm-tools#668 - An error related to macaroonbakery fixed in charm-tools 2.8.9: juju/charm-tools#671 Additionally merge bindep.txt to install libpq-dev required for psycopg2-binary as wheels no longer exist for py36. Additional fix for ussuri only: - Switch bionic test bundles from vault 1.7/edge to 1.6/edge as the 1.7 channel no longer supports bionic. Change-Id: Idc16b84dc3dcdf001c73c7d2fdd57b1d08ebfb23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macaroonbakery in v1.3.4 added a constraint of protobuf>=3.20.0[0] which makes it incompatible with python 3.6 and v1.3.3 was released in a broken state[1].