setup: Update charm-tools pin set #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is similar to #656 - could we please consolidate them? So we also need to pin |
ajkavanagh
suggested changes
Jul 21, 2023
pyyaml 5.4.0 and 5.4.1 are broken with cython 3 yaml/pyyaml#724 jsonschema 4.18.0 depends on Rust (via rpds-py) Co-authored-by: Felipe Reyes <[email protected]>
ajkavanagh
approved these changes
Aug 2, 2023
|
we need a 3.0.7 release in pypi with this fix |
3 tasks
|
This change should be revisited now that 6.0.1 was released to fix the problem. I'm not sure, but it looks like the result of 'pyyaml>=5.0,!=5.4.0,!=5.4.1,<6.0' is 5.3.1, which has known CVEs. |
|
On Wed, 2023-08-09 at 12:58 -0700, Mark Beierl wrote:
This change should be revisited now that 6.0.1 was released to fix the problem. I'm not sure, but
it looks like the result of 'pyyaml>=5.0,!=5.4.0,!=5.4.1,<6.0' is 5.3.1, which has known
CVEs.
pip install 'pyyaml>=5.0,!=5.4.0,!=5.4.1,<6.0'
Collecting pyyaml!=5.4.0,!=5.4.1,<6.0,>=5.0
Using cached PyYAML-5.3.1-cp311-cp311-linux_x86_64.whl
Installing collected packages: pyyaml
Successfully installed pyyaml-5.3.1
I think we could do:
pyyaml>=5.0,!=5.4.0,!=5.4.1,!=6.0,<7.0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyyaml 5.4.0 and 5.4.1 are broken with cython 3
yaml/pyyaml#724
jsonschema 4.18.0 depends on Rust (via rpds-py)