feat(focus): unfocus a task after it has been completed #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focussing on a task is a nice addition!
But it bugged me a little when you mark something as done, that it would still be shown as being focussed on, to me it makes sense to unfocus the task.
Sidenote: it took me by surprise that there are a bunch of tests for the User and UserList, but it doesn't actually cover the actual result in the end as the dom changes aren't based on the current model state. It might be nice to simply rerender the whole task when something changes, instead of trying to sync the state of the dom and the state of the underlaying models? Something like
this.rerenderTask(id)instead ofthis.completeTaskFromDOM(id)?