Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/excel writer #1252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/excel writer #1252

wants to merge 2 commits into from

Conversation

roelandmaes
Copy link

@roelandmaes roelandmaes commented Apr 19, 2024 •
edited
Loading

Thanks for contributing.

Description

XlsxWriter: class to write Table to Excel files.
XlsxWriteOptions: Class to finetune the exported Excel files

  • column width
  • date(time) format
  • auto filter (on/off)
  • Freeze row/column

Testing

Nope

@roelandmaes roelandmaes reopened this Apr 19, 2024
benmccann

This comment was marked as duplicate.

Sign in to view

benmccann
benmccann requested changes Jan 2, 2025
View reviewed changes
Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason you opened a new PR and we shouldn't use #1207? I'm inclined to close this PR in favor of that one as it has tests

@benmccann
Copy link
Collaborator

I merged the other one. Please feel free to rebase and send changes if there are additional features you'd like

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
7.8% Duplication on New Code (required ≤ 3%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roelandmaes @benmccann