Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🤖 upgrade to angular v18 #773

Closed
wants to merge 3 commits into from
Closed

chore: 🤖 upgrade to angular v18 #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
773925b
chore: 🤖 upgrade to angular 18
chimurai Jun 19, 2024
968f2ba
chore: 🤖 bump @ngneat/spectator to v19
chimurai Jun 19, 2024
89a3741
chore: 🤖 npm audit fix
chimurai Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,18 @@
"groups": ["builtin", "external", "internal", "parent", "sibling"],
"newlines-between": "always"
}
]
],
"@typescript-eslint/no-extra-semi": "error",
"no-extra-semi": "off"
}
},
{
"files": ["*.js", "*.jsx"],
"extends": ["plugin:@nx/javascript"],
"rules": {}
"rules": {
"@typescript-eslint/no-extra-semi": "error",
"no-extra-semi": "off"
}
},
{
"files": ["**/*.spec.ts", "**/mocks.ts", "**/test-setup.ts"],
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,6 @@ Thumbs.db
apps/transloco-playground-e2e/cypress/screenshots/*

.nx/cache
.nx/workspace-data

.nx
2 changes: 2 additions & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@
/docs/docs

/.nx/cache

/.nx/workspace-data
9 changes: 4 additions & 5 deletions apps/transloco-playground-e2e/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "apps/transloco-playground-e2e/src",
"projectType": "application",
"tags": [],
"implicitDependencies": ["transloco-playground"],
"targets": {
"e2e": {
"executor": "@nx/cypress:cypress",
Expand All @@ -19,10 +21,7 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
}
},
"tags": [],
"implicitDependencies": ["transloco-playground"]
}
}
7 changes: 3 additions & 4 deletions apps/transloco-playground/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"projectType": "application",
"sourceRoot": "apps/transloco-playground/src",
"prefix": "transloco-nx-shell",
"tags": [],
"targets": {
"build": {
"executor": "@nx/angular:webpack-browser",
Expand Down Expand Up @@ -76,8 +77,7 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"test": {
"executor": "@angular-devkit/build-angular:karma",
Expand All @@ -87,6 +87,5 @@
"karmaConfig": "apps/transloco-playground/karma.conf.js"
}
}
},
"tags": []
}
}
2 changes: 1 addition & 1 deletion apps/transloco-playground/src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@
/>
</head>
<body>
<app-root />
<app-root></app-root>
</body>
</html>
7 changes: 3 additions & 4 deletions libs/transloco-locale/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"projectType": "library",
"sourceRoot": "libs/transloco-locale/src",
"prefix": "transloco-nx-shell",
"tags": [],
"targets": {
"build": {
"executor": "@nx/angular:package",
Expand All @@ -30,12 +31,10 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"version": {
"executor": "@jscutlery/semver:version"
}
},
"tags": []
}
}
7 changes: 3 additions & 4 deletions libs/transloco-messageformat/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"projectType": "library",
"sourceRoot": "libs/transloco-messageformat/src",
"prefix": "transloco-nx-shell",
"tags": [],
"targets": {
"build": {
"executor": "@nx/angular:package",
Expand All @@ -30,12 +31,10 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"version": {
"executor": "@jscutlery/semver:version"
}
},
"tags": []
}
}
7 changes: 3 additions & 4 deletions libs/transloco-optimize/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "libs/transloco-optimize/src",
"projectType": "library",
"tags": [],
"targets": {
"build": {
"executor": "@nx/js:tsc",
Expand All @@ -15,8 +16,7 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"test": {
"executor": "@angular-devkit/build-angular:karma",
Expand All @@ -29,6 +29,5 @@
"version": {
"executor": "@jscutlery/semver:version"
}
},
"tags": []
}
}
7 changes: 3 additions & 4 deletions libs/transloco-persist-lang/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"projectType": "library",
"sourceRoot": "libs/transloco-persist-lang/src",
"prefix": "transloco-nx-shell",
"tags": [],
"targets": {
"build": {
"executor": "@nx/angular:package",
Expand All @@ -30,12 +31,10 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"version": {
"executor": "@jscutlery/semver:version"
}
},
"tags": []
}
}
7 changes: 3 additions & 4 deletions libs/transloco-persist-translations/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"projectType": "library",
"sourceRoot": "libs/transloco-persist-translations/src",
"prefix": "transloco-nx-shell",
"tags": [],
"targets": {
"build": {
"executor": "@nx/angular:package",
Expand All @@ -30,12 +31,10 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"version": {
"executor": "@jscutlery/semver:version"
}
},
"tags": []
}
}
7 changes: 3 additions & 4 deletions libs/transloco-preload-langs/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"projectType": "library",
"sourceRoot": "libs/transloco-preload-langs/src",
"prefix": "transloco-nx-shell",
"tags": [],
"targets": {
"build": {
"executor": "@nx/angular:package",
Expand All @@ -30,12 +31,10 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"version": {
"executor": "@jscutlery/semver:version"
}
},
"tags": []
}
}
7 changes: 3 additions & 4 deletions libs/transloco-schematics/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "libs/transloco-schematics/src",
"projectType": "library",
"tags": [],
"targets": {
"build": {
"executor": "@nx/js:tsc",
Expand All @@ -26,8 +27,7 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"test": {
"executor": "@nx/jest:jest",
Expand All @@ -36,6 +36,5 @@
"jestConfig": "libs/transloco-schematics/jest.config.ts"
}
}
},
"tags": []
}
}
7 changes: 3 additions & 4 deletions libs/transloco-scoped-libs/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "libs/transloco-scoped-libs/src",
"projectType": "library",
"tags": [],
"targets": {
"build": {
"executor": "@nx/js:tsc",
Expand All @@ -15,8 +16,7 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"test": {
"executor": "@angular-devkit/build-angular:karma",
Expand All @@ -29,6 +29,5 @@
"version": {
"executor": "@jscutlery/semver:version"
}
},
"tags": []
}
}
7 changes: 3 additions & 4 deletions libs/transloco-utils/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "libs/transloco-utils/src",
"projectType": "library",
"tags": [],
"targets": {
"build": {
"executor": "@nx/js:tsc",
Expand All @@ -15,8 +16,7 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"test": {
"executor": "@angular-devkit/build-angular:karma",
Expand All @@ -29,6 +29,5 @@
"version": {
"executor": "@jscutlery/semver:version"
}
},
"tags": []
}
}
7 changes: 3 additions & 4 deletions libs/transloco-validator/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"$schema": "../../node_modules/nx/schemas/project-schema.json",
"sourceRoot": "libs/transloco-validator/src",
"projectType": "library",
"tags": [],
"targets": {
"build": {
"executor": "@nx/js:tsc",
Expand All @@ -15,8 +16,7 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"test": {
"executor": "@angular-devkit/build-angular:karma",
Expand All @@ -29,6 +29,5 @@
"version": {
"executor": "@jscutlery/semver:version"
}
},
"tags": []
}
}
7 changes: 3 additions & 4 deletions libs/transloco/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"projectType": "library",
"sourceRoot": "libs/transloco/src",
"prefix": "transloco-nx-shell",
"tags": [],
"targets": {
"build": {
"executor": "@nx/angular:package",
Expand All @@ -30,12 +31,10 @@
}
},
"lint": {
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"]
"executor": "@nx/eslint:lint"
},
"version": {
"executor": "@jscutlery/semver:version"
}
},
"tags": []
}
}
2 changes: 1 addition & 1 deletion libs/transloco/src/lib/tests/inline-loaders.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import { createFactory } from './directive/shared';

const inlineLoaders = provideTranslocoScope(inlineScope);

function updateView<T>(spectator: Spectator<T>, service: TranslocoService) {
function updateView<T>(spectator: Spectator<T> | SpectatorHost<T>, service: TranslocoService) {
runLoader();
spectator.detectChanges();
expect(spectator.query('span')).toHaveText('Todos Title English');
Expand Down
Loading
Loading