-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 🤖 upgrade to nx17 #734
Conversation
Upgrading to nx17 using npx nx migrate latest ✅ Closes: jsverse#731
Run & review this pull request in StackBlitz Codeflow. |
@alexdabast Thanks for the PR! |
@shaharkazaz I will look into the tests failing |
I'll clarify, I meant running the new syntax migration so that the playground code will use it |
Html template of the playground has been migrated using angular cli ng generate @angular/core:control-flow
@shaharkazaz I have run the migration and did some test seems ok Also had to replace runSchematicAsync by runSchematic and remove the conversion to promise as it returns now directly a promise |
|
Any news on this? |
Thanks for your work on this PR, @alexdabast. Do you still have the time to push this forward? If not, I would be happy to support you in completing the remaining points :) |
The repository is already using nx v17 |
Upgrading to nx17 using npx nx migrate latest
✅ Closes: #731
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Nx upgrade version
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
I did not manually bump any devPeer in libs folder as I don't think it is required to do that