Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[is]: is* functions allows symbol properties #97

Merged
merged 18 commits into from
Aug 11, 2024

Conversation

Milly
Copy link
Collaborator

@Milly Milly commented Aug 8, 2024

Implements to these functions:

  • inspect
  • isIntersectionOf
  • isObjectOf
  • isOmitOf
  • isPartialOf
  • isPickOf
  • isReadonlyOf (Maybe not necessary)
  • isRecordObjectOf
  • isRecordOf
  • isRequiredOf
  • isStrictOf

Refs #94, #95

@Milly Milly added bug Something isn't working enhancement New feature or request labels Aug 8, 2024
@Milly Milly marked this pull request as draft August 8, 2024 12:56
@Milly Milly mentioned this pull request Aug 8, 2024
10 tasks
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (e9fd92e) to head (4a5dc04).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   98.09%   98.16%   +0.06%     
==========================================
  Files          50       50              
  Lines         841      872      +31     
  Branches       85       89       +4     
==========================================
+ Hits          825      856      +31     
  Misses         16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lambdalisue lambdalisue modified the milestones: v4, v4.1 Aug 8, 2024
@Milly Milly marked this pull request as ready for review August 10, 2024 10:57
@Milly Milly changed the title WIP: implement symbol properties feat[is]: is* functions allows symbol properties Aug 10, 2024
@Milly Milly requested a review from lambdalisue August 10, 2024 10:59
@Milly Milly marked this pull request as draft August 10, 2024 23:52
@Milly
Copy link
Collaborator Author

Milly commented Aug 10, 2024

Wait #115 to merge.

@lambdalisue lambdalisue marked this pull request as ready for review August 11, 2024 00:43
@lambdalisue lambdalisue merged commit 123572a into main Aug 11, 2024
6 checks passed
@lambdalisue lambdalisue deleted the symbol-properties-wip branch August 11, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants