Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[isRecordOf]: checks own symbol key properties #113

Merged
merged 2 commits into from
Aug 10, 2024

Conversation

Milly
Copy link
Collaborator

@Milly Milly commented Aug 9, 2024

Contains bug fixes. See comments in #110.

@Milly Milly requested a review from lambdalisue August 9, 2024 07:09
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (4ec8855) to head (b907473).

Additional details and impacted files
@@                  Coverage Diff                   @@
##           symbol-properties-wip     #113   +/-   ##
======================================================
  Coverage                  98.04%   98.05%           
======================================================
  Files                         50       50           
  Lines                        817      821    +4     
  Branches                      88       88           
======================================================
+ Hits                         801      805    +4     
  Misses                        16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lambdalisue lambdalisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Milly Milly merged commit 05cebb7 into symbol-properties-wip Aug 10, 2024
6 checks passed
@Milly Milly deleted the symbol-properties/record-of branch August 10, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants