Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixing text size in TableOfContent component #711

Merged
merged 2 commits into from
May 25, 2024
Merged

Fix: Fixing text size in TableOfContent component #711

merged 2 commits into from
May 25, 2024

Conversation

DhairyaMajmudar
Copy link
Member

What kind of change does this PR introduce?
Fixing text size such that it matches rest of the page.

Issue Number:

Screenshots/videos:
image

If relevant, did you update the documentation?
N/A

Summary
Text size is now fixed.

@DhairyaMajmudar DhairyaMajmudar requested a review from a team as a code owner May 24, 2024 14:05
benjagm
benjagm requested changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font size looks good. The only thing I found is the horizontal lines dots thickness what seems to have increased compared with the production version. We'd like those dots to have the same thickness than the vertical line dots.

@DhairyaMajmudar
Copy link
Member Author

Font size looks good. The only thing I found is the horizontal lines dots thickness what seems to have increased compared with the production version. We'd like those dots to have the same thickness than the vertical line dots.

I have commited the changes : )

benjagm
benjagm approved these changes May 25, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@benjagm benjagm merged commit faf974d into json-schema-org:main May 25, 2024
3 checks passed
aialok pushed a commit to aialok/website that referenced this pull request May 27, 2024
@DhairyaMajmudar @aialok
Fix: Fixing text size in TableOfContent component (json-schema-org#711)
c30280b 
* fixing text size

* resizing dots
@DhairyaMajmudar DhairyaMajmudar deleted the table branch May 27, 2024 16:52
Akshaybagai52 pushed a commit to Akshaybagai52/website that referenced this pull request Jun 2, 2024
@DhairyaMajmudar @Akshaybagai52
Fix: Fixing text size in TableOfContent component (json-schema-org#711)
e08c135 
* fixing text size

* resizing dots
@DhairyaMajmudar DhairyaMajmudar added the GSoD Google Season of Docs label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjagm benjagm benjagm approved these changes

Assignees
No one assigned
Labels
GSoD Google Season of Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Small text in tableOfContent
2 participants
@DhairyaMajmudar @benjagm