Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Validating OpenAPI and JSON Schema" post #704

Merged

Conversation

jdesrosiers
Copy link
Member

I saw a question on StackOverflow that asked about validating OpenAPI documents with a custom JSON Schema dialect. I pointed them toward this blog post that answers part of their question, but I realized there are some brief code examples that use an old version of @hyperjump/json-schema, so I wanted to update those examples.

@jdesrosiers jdesrosiers requested a review from a team as a code owner May 21, 2024 10:00
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with this article! I learned a lot while reading it. I think there is range for more posts in this intersection between OpenAPI and JSON Schema.

Looks great to me. My only thought regarding the format of the article: The article ends after the last sub-section of the "Supporting multiple dialects" with a cold end for what was a great article. My suggestion is adding a closing paragraph or closing thoughts section to avoid that cold end.

@gregsdennis
Copy link
Member

Do we want to change the spirit of the article? I think this change is just updating for relevant code samples.

@benjagm
Copy link
Collaborator

benjagm commented May 23, 2024

Do we want to change the spirit of the article?

It is all right from my side. I approved the PR but also shared my opinion just in case it resonates to Jason.

@jdesrosiers
Copy link
Member Author

@benjagm is absolutely right that this post would be better if it had a proper conclusion. I remember writing it and couldn't think of a way to end it. I don't have a problem with updating an old post, but I'm a bit overloaded at the moment and don't want to delay releasing this update until I have time to come back to this and work on adding a conclusion. I'll put that on my list and hopefully get to it sometime in the near future.

@jdesrosiers jdesrosiers merged commit 1d7b007 into json-schema-org:main May 24, 2024
5 checks passed
@jdesrosiers jdesrosiers deleted the update-validating-openapi branch May 24, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants