-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add table of contents and tabs group to style guide #669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentions a blocker and clarification. Any help on blocker appreciated.
pages/md-style-guide.md
Outdated
[tabs-start "label"] | ||
[tab "name"] | ||
message to show | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I add this line:
[tabs-end]
This gets treated as a tab group and gets rendered rather than displaying as a code block. Any help on this appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding one newline [enter] might help in this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DhairyaMajmudar Is this what you meant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, add newline before [tab-end]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still the same😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added newline before, after and both. All three yeild the same result as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me check if I can find any another solution 👍🏻
@DhairyaMajmudar Yes this works fine to render but there's a catch. Say I copy paste this and try to render the component, this doesn't work. Explicitly I need to remove the spaces, only then the implementation works. If this is fine then I'm ready to update. What's ur view on this. |
I'm not fond of how the example ToC renders. Is there anything we can do to make it look more like a ToC and not just s bunch of "example" links? |
@gregsdennis Currently I have set the depth as 5 and it renders the contents for the specific file. So it shows like that. Let me try other possible methods and let you know if any that is better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/* margin-right: 10px; */ | ||
/* display: flex; */ | ||
/* border: 1px solid #E3E8EE; | ||
/* background-color: transparent !important; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to modify the css to just add to new tags to the style guide. I think your are adding here your work to modify the design of the table of contents but we should avoid it. Please use two different branches to fix each issue.
@@ -1,145 +1,230 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was all of this content replaced with what looks like primarily CSS? Where is this content now?
@gregsdennis @benjagm Will make a new PR. Closing this due to incorrect commit. |
What kind of change does this PR introduce?
Update Style Guide
Issue Number:
Screenshots/videos: