Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Making dark mode consistent for tabsgroup and thead #645

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Feat: Making dark mode consistent for tabsgroup and thead #645

merged 2 commits into from
Apr 15, 2024

Conversation

DhairyaMajmudar
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar commented Apr 11, 2024 •
edited
Loading

What kind of change does this PR introduce?

  1. Making dark mode consistent for tabsgroup.
  2. Making dark mode consistent for thead.
  3. Imporved gradient color.

Issue Number:

Screenshots/videos:

Before

Tabsgroup
image

Thead
image

After

Tabsgroup
image

Thead
image

@DhairyaMajmudar DhairyaMajmudar requested a review from a team as a code owner April 11, 2024 13:32
@DhairyaMajmudar DhairyaMajmudar changed the title Feat: Making dark mode consistent for array section Feat: Making dark mode consistent for tabsgroup and thead Apr 12, 2024
officeneerajsaini
officeneerajsaini approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@officeneerajsaini officeneerajsaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

benjagm
benjagm approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks for fixing this.

@benjagm benjagm merged commit e3c77af into json-schema-org:main Apr 15, 2024
2 checks passed
@DhairyaMajmudar DhairyaMajmudar deleted the dark_mode branch April 15, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@officeneerajsaini officeneerajsaini officeneerajsaini approved these changes

@benjagm benjagm benjagm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Inconsistent text color in dark mode under array section of docs
3 participants
@DhairyaMajmudar @benjagm @officeneerajsaini