-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Adding Openapi Links #382
Conversation
Hey there 👋! Are you an implementer of a new JSON Schema related tool, or an interested user submitting a tool you like? Someone will review your pull request shortly. In the interim, if you haven't already, there's a few things you might be interested in reviewing or confirming:
If you have any questions, any feedback, or need help with the submission process, don't hesitate to reach out. |
@benjagm @karenetheridge pls. have a look, I have added the links to about 6 places where it felt relevant to me. If you needed links to be added in more places I will be happy to do so : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions. I think we should add the link to the OpenAPI subcategory in the Format converters section too.
Good job here!
Co-authored-by: Benjamin Granados <[email protected]>
Co-authored-by: Benjamin Granados <[email protected]>
Co-authored-by: Benjamin Granados <[email protected]>
Thank you @benjagm, I have made the suggested changes. |
Before merging, could this be rebased+squashed please? |
Yeah sure |
GitHub Issue: #127
closes #127
Summary:
Added OpenAPI links to the website, changed the
openAPI
text to openAPI links which redirects to the open API website. The links are added to 6 relevant places.Files Changed
pages/implementations/main.md
Screenshot Before
Screenshot After
Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)
No
[JUSTIFICATION]