Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

side bar drop down fix #1363

Closed
wants to merge 2 commits into from
Closed

Conversation

Chayan8837
Copy link

What kind of change does this PR introduce?

Bug Fix: Sidebar Dropdown for Specification Tab

Overview

This fix addresses a bug in the sidebar dropdown functionality for the specification tab. Previously, the dropdown would automatically open when the URL matched but would not close when the URL or active tab changed. This led to inconsistent behavior and a suboptimal user experience.


Issue Number:

Screenshots/videos:

Screencast.from.2025-01-23.23-50-26.-.Converted.mp4

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

  • None. This fix maintains backward compatibility.

@Chayan8837 Chayan8837 requested a review from a team as a code owner January 23, 2025 18:30
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Jan 23, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 70d3c6f

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ee9538b) to head (70d3c6f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1363   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DhairyaMajmudar
Copy link
Member

DhairyaMajmudar commented Jan 23, 2025

@Chayan8837 pls. don't open PR without issue assignment and follow our contributing guidelines

@Chayan8837
Copy link
Author

ok sir, i don't know about it , so can you please assign me for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: dropdown should close automatically when navigate to another page
2 participants