Bug: #1281 fixed, [Dark/Light Mode Toggle Doesn't Close Automatically on Mobile] #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Automatically on Mobile]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1329 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 383 +10
Branches 94 97 +3
=========================================
+ Hits 373 383 +10 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… on Mobile]
What kind of change does this PR introduce?
bugfix: Fixes Dark/Light Mode Toggle Doesn't Close Automatically on Mobile.
Issue Number:
Closes #1281
Screenshots/videos:
Here is a screen recording
Screen.Recording.2025-01-19.at.3.16.04.PM.online-video-cutter.com.mp4
If relevant, did you update the documentation?
No documentation change
Summary
Before:
If user interacts outside of the toggle menu on mobile devices then the theme toggle menu was staying there .
After:
Now it will close the theme toggle menu when user interacts with other page items on mobile devices
Does this PR introduce a breaking change?
No Breaiking Changes