Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : pro help sidebar alignment and add buttons #1310

Merged

Conversation

Karan-Palan
Copy link
Contributor

What kind of change does this PR introduce?

  1. Pro Help Page Sidebar and Navigation Buttons:
  • Added "Go Back" and "Up Next" buttons to the Pro Help page for consistent
  • Aligned the sidebar to match the logical flow of pages: Case Studies → FAQ → Pro Help → Similar
  • Fixed layout misalignment issues on the top and left of the Pro Help page.
  1. Arrow Navigation Updates Across Pages

Issue Number:

Screenshots/videos:

Screencast.from.2025-01-14.13-31-31.webm

If relevant, did you update the documentation?
No

Summary

#1291 - Fixes Pro Help page sidebar alignment, adds navigation buttons, and standardizes arrow navigation across pages.

Does this PR introduce a breaking change?

No

@Karan-Palan Karan-Palan requested a review from a team as a code owner January 14, 2025 08:06
Copy link

github-actions bot commented Jan 14, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 255fabc

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4fe7488) to head (255fabc).
Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1310   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Karan-Palan
Copy link
Contributor Author

I have moved the /pro-help page to overview/pro-help as it was in the overview sidebar to maintain consistency in the website. If that isn't required, I'd revert it back to /pro-help

@Karan-Palan Karan-Palan changed the title Fix/pro help sidebar alignment Fix : pro help sidebar alignment and add buttons Jan 22, 2025
@DhairyaMajmudar DhairyaMajmudar self-requested a review January 22, 2025 13:34
Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@DhairyaMajmudar DhairyaMajmudar added the ready-to-merge PR that already has two approvals. label Jan 31, 2025
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit 7b128df into json-schema-org:main Feb 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge PR that already has two approvals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Inconsistent Navigation Buttons and Sidebar Order in Documentation
3 participants