Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ignore Brackets Inside Strings in getPartsOfArrayContent #1268

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions lib/getPartsOfJson.ts
Original file line number Diff line number Diff line change
Expand Up @@ -366,21 +366,30 @@ const getPartsOfArrayContent = (
const length = match.index - arrayPayloadIndex;
const payload = serializedJson.substr(arrayPayloadIndex, length);

//ToDo filter brackets in strings
const stringMatches = getFindResultsByGlobalRegExp(payload, regexString);
let filteredPayload = payload;

// Replace content of strings with placeholders to avoid counting brackets inside them
stringMatches.forEach((stringMatch) => {
const stringContent = stringMatch.match;
const placeholder = '_'.repeat(stringContent.length);
filteredPayload = filteredPayload.replace(stringContent, placeholder);
});

const countOpenCurlyBracketsInPayload = getFindResultsByGlobalRegExp(
payload,
filteredPayload,
/\{/g,
).length;
const countClosedCurlyBracketsInPayload = getFindResultsByGlobalRegExp(
payload,
filteredPayload,
/\}/g,
).length;
const countOpenSquaredBracketsInPayload = getFindResultsByGlobalRegExp(
payload,
filteredPayload,
/\[/g,
).length;
const countClosedSquaredBracketsInPayload = getFindResultsByGlobalRegExp(
payload,
filteredPayload,
/\]/g,
).length;
const openCurlyBrackets =
Expand Down
Loading