Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed SearchIcon background bug #1215

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

abhayymishraa
Copy link
Contributor

What kind of change does this PR introduce?

Bug FIx : Search Icon background bug

Issue Number:

Screenshots/videos:

Aftere the chnages - >

Dark ->
Screenshot from 2024-12-26 20-10-52

Light->
Screenshot from 2024-12-26 20-11-07

If relevant, did you update the documentation?
N/A

Summary

Does this PR introduce a breaking change?
N/A Just Solved bug

@abhayymishraa abhayymishraa requested a review from a team as a code owner December 27, 2024 10:57
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Dec 27, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview df37786

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5114356) to head (df37786).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1215   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@abhayymishraa
Copy link
Contributor Author

yes @DhairyaMajmudar minor changes !!!

@benjagm benjagm merged commit e7706e2 into json-schema-org:main Jan 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Search logo bug on developmet
3 participants