Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1041 Add missing alt attribute to images #1211

Conversation

CharitSinghChauhan
Copy link

What kind of change does this PR introduce?
This PR introduces a bugfix to ensure all images in the specified pages have descriptive alt attributes for improved accessibility.

Issue Number: closes #1041

Screenshots/videos:
N/A

If relevant, did you update the documentation?
No documentation updates are necessary as this is a code-level change.

Summary:
The changes in this PR address the missing alt attributes in images on two pages located in the components/Layout.tsx and
pages/index.page.tsx directory. Adding descriptive alt attributes enhances accessibility and ensures compliance with web standards.

Does this PR introduce a breaking change?
No breaking changes introduced.

@CharitSinghChauhan CharitSinghChauhan requested a review from a team as a code owner December 26, 2024 21:19
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

@CharitSinghChauhan CharitSinghChauhan deleted the CharitSingChauhan-add-missing-alt-attribute-to-images branch December 26, 2024 22:21
@CharitSinghChauhan CharitSinghChauhan restored the CharitSingChauhan-add-missing-alt-attribute-to-images branch December 26, 2024 22:22
@CharitSinghChauhan
Copy link
Author

CharitSinghChauhan commented Dec 26, 2024

how can I improve my code quality to pass the code quality check?"
@DhairyaMajmudar

@benjagm
Copy link
Collaborator

benjagm commented Dec 27, 2024

Thanks a lot for this PR. Do you mind closing it and wait until the related issue is properly assigned?

@CharitSinghChauhan
Copy link
Author

Thank you for reviewing the PR! I completely understand. I’ll go ahead and close it for now and will wait until the related issue is properly assigned. Please feel free to let me know if there’s anything else I can do in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Add missing alt attribute to images
2 participants