Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on Dockerfile Implementation for Windows Users #1204

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

Adi-204
Copy link
Contributor

@Adi-204 Adi-204 commented Dec 23, 2024

What kind of change does this PR introduce?
Added the corepack enable command in the Dockerfile. This adjustment ensures that the correct version of Yarn is used consistently across different environments.

Closes #1196

If relevant, did you update the documentation?
Updated the 'Local Setup Using Docker' documentation to include steps for setting up the project locally for Windows users.

Summary
The current implementation of our Dockerfile, particularly for Windows users.
Key Issues:

  1. Incompatibility with make Command
  2. Yarn Version Mismatch Error
    Solution:
    To added the corepack enable command in the Dockerfile. This adjustment ensures that the correct version of Yarn is used consistently across different environments.

@Adi-204 Adi-204 requested a review from a team as a code owner December 23, 2024 10:42
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Dec 23, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 6dd9ed4

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8676fc2) to head (6dd9ed4).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1204   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Relequestual Relequestual merged commit 6dd9ed4 into json-schema-org:main Dec 27, 2024
10 of 11 checks passed
@Relequestual
Copy link
Member

I'm not sure what happened, but I did not intend to merge this PR. Quite confused.
I merged one other PR which was #1213, but not this one.

@DhairyaMajmudar
Copy link
Member

I'm not sure what happened, but I did not intend to merge this PR. Quite confused. I merged one other PR which was #1213, but not this one.

Hi Ben, the PR you merged was having three commits....

  1. Commit same as this PR
  2. Commit reverting the previous
  3. The original changes for which that PR is supposed to.

In the last PR merge, all of those three commits are merged all together which resulted in merge of this PR too.

@Relequestual
Copy link
Member

Thanks for picking this up @DhairyaMajmudar, just worked out the same.
I only checked the files changed and not the commits. I didn't know this could happen. Never seen it before!

git rebase is preferable to remove commits accidentally included in a PR =]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Update on Dockerfile Implementation for Windows Users
3 participants