-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update on Dockerfile Implementation for Windows Users #1204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1204 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
I'm not sure what happened, but I did not intend to merge this PR. Quite confused. |
Hi Ben, the PR you merged was having three commits....
In the last PR merge, all of those three commits are merged all together which resulted in merge of this PR too. |
Thanks for picking this up @DhairyaMajmudar, just worked out the same. git rebase is preferable to remove commits accidentally included in a PR =] |
What kind of change does this PR introduce?
Added the corepack enable command in the Dockerfile. This adjustment ensures that the correct version of Yarn is used consistently across different environments.
Closes #1196
If relevant, did you update the documentation?
Updated the 'Local Setup Using Docker' documentation to include steps for setting up the project locally for Windows users.
Summary
The current implementation of our Dockerfile, particularly for Windows users.
Key Issues:
Solution:
To added the corepack enable command in the Dockerfile. This adjustment ensures that the correct version of Yarn is used consistently across different environments.