Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Sponsor Buttons #1154

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Fixed Sponsor Buttons #1154

merged 4 commits into from
Dec 13, 2024

Conversation

IyaadArshad
Copy link
Contributor

What kind of change does this PR introduce?
Fix for #1067

Issue Number:

Notes:

  • Sponsor Links now directly take you to checkout for that particulator selection (Example: Gold Sponsor button now takes you the gold sponsor checkout instead of all options)
  • Sponsor Links open in a new tab
  • Removed dotted border around sponsor buttons

@IyaadArshad IyaadArshad requested a review from a team as a code owner December 9, 2024 14:59
Copy link

github-actions bot commented Dec 9, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 0c4047a

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (85bb2fa) to head (0c4047a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1154   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Relequestual
Copy link
Member

Thanks for your PR on this. Can we add the dotted line back please? =]

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!!

@benjagm benjagm merged commit 43aef96 into json-schema-org:main Dec 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Sponsors Button Not Working Correctly
3 participants