Link-Redirect-fix-DocsHelp-Component #1117
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1117 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 381 +8
Branches 94 97 +3
=========================================
+ Hits 373 381 +8 ☔ View full report in Codecov by Sentry. |
|
@DarhkVoyd This is the new pull request for this closed pull request #1046 because of some git pull rebase issues. I have written all the tests and changed all the corrections that you said in that #1046 closed pull request. Sry for closing that pull request. |
|
@aialok Is everything fine with the pr ? Is there any one want to review it? |
There was a problem hiding this comment.
Hey, thanks for working on this. This is almost done, just a few suggestions:
- We can get rid of the
console.log - Since the prop name has been updated to
fileRenderType, let's update the passed argument variable name to reflect the change. As I have suggested at one of the instances.
|
@DarhkVoyd Done with all the changes suggested. |
|
@Yashwanth1906 Hey, could you please resolve the conflicts in the PR? I'll review this PR soon. |
|
@DarhkVoyd ok Ill finsih this as soon as possible |
|
Hey @Yashwanth1906 You don't have to close existing PR and create a new PR for each change/review, you can continue working on the same branch and PR, we'll squash merge it. |
|
@DarhkVoyd ok |
|
@DarhkVoyd Hi, I have tried pulling and merging the files and it resulted in mess and i added some packages and now im superconfused how to resolve this thing. Could I make another clean PR with all the tests and changes that you told in this PR. |
|
@Yashwanth1906 Sure, no worries. |
What kind of change does this PR introduce?
Change to correct wrong redirecting URLs
Issue Number:
closes: #1038
Screenshots/videos:
If relevant, did you update the documentation?
Summary
This pull request addresses an issue related to incorrect URL redirection in the JSON Schema website. Users were being redirected to incorrect or unintended pages when clicking on certain links.
Changes Made:
Corrected Redirecting URLs: Updated the wrong redirecting URLs in various components to ensure they point to the correct destinations. This change enhances navigation and provides users with access to the intended content.
Refactored JSX Components: Adjusted the formatting of JSX components to comply with the project's style guide. Specifically, I ensured that there were proper spaces before closing brackets in the JSX tags, addressing the errors raised by the reviewers.
Code Consistency: Ensured consistency in the codebase by adhering to Prettier and ESLint rules, which included correcting formatting issues to enhance code readability and maintainability.
These changes improve user experience by ensuring that links function correctly, reducing frustration caused by misdirected navigation.
Does this PR introduce a breaking change?
No