-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement : hide edit this on github #1114
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1114 +/- ##
===========================================
- Coverage 100.00% 99.73% -0.27%
===========================================
Files 10 10
Lines 373 375 +2
Branches 94 97 +3
===========================================
+ Hits 373 374 +1
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. |
Please see my comment on the issue |
@arpitkuriyal Hey, any update on this? Are the changes suggested by @gregsdennis updated in this? |
Hello @DarhkVoyd,Could you please guide me on what to do next? Am I supposed to write tests for the code I have written to verify the checks that have failed or is there something else I need to address?I’m a bit confused, and I have also written about this in Slack, but I haven’t received any replies yet. |
Please, check this test for this component here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be fixed by: #1187
Closed in favour of #1187 it seems we had a duplicity here. Thanks for your contrubition. |
What kind of change does this PR introduce?
Add a prop that default feature is to show the "edit this on github " button but when pass false it hide that button
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?