Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement : hide edit this on github #1114

Closed
wants to merge 2 commits into from

Conversation

arpitkuriyal
Copy link
Contributor

What kind of change does this PR introduce?

Add a prop that default feature is to show the "edit this on github " button but when pass false it hide that button

Issue Number:

Screenshots/videos:

Screenshot 2024-11-14 at 3 35 06 PM

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@arpitkuriyal arpitkuriyal requested a review from a team as a code owner November 14, 2024 10:24
Copy link

github-actions bot commented Nov 14, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 71e2039

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.73%. Comparing base (9899bc7) to head (71e2039).
Report is 84 commits behind head on main.

Files with missing lines Patch % Lines
components/DocsHelp.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #1114      +/-   ##
===========================================
- Coverage   100.00%   99.73%   -0.27%     
===========================================
  Files           10       10              
  Lines          373      375       +2     
  Branches        94       97       +3     
===========================================
+ Hits           373      374       +1     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gregsdennis
Copy link
Member

Please see my comment on the issue

#1099 (comment)

@DarhkVoyd
Copy link
Member

DarhkVoyd commented Nov 26, 2024

@arpitkuriyal Hey, any update on this? Are the changes suggested by @gregsdennis updated in this?

@arpitkuriyal
Copy link
Contributor Author

Hello @DarhkVoyd,Could you please guide me on what to do next? Am I supposed to write tests for the code I have written to verify the checks that have failed or is there something else I need to address?I’m a bit confused, and I have also written about this in Slack, but I haven’t received any replies yet.

@benjagm benjagm requested a review from DarhkVoyd December 27, 2024 09:41
@benjagm
Copy link
Collaborator

benjagm commented Jan 7, 2025

Hello @DarhkVoyd,Could you please guide me on what to do next? Am I supposed to write tests for the code I have written to verify the checks that have failed or is there something else I need to address?I’m a bit confused, and I have also written about this in Slack, but I haven’t received any replies yet.

Please, check this test for this component here:
/cypress/components/DocsHelp.cy.tsx

@DarhkVoyd DarhkVoyd mentioned this pull request Jan 9, 2025
Copy link
Member

@DarhkVoyd DarhkVoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should be fixed by: #1187

@benjagm
Copy link
Collaborator

benjagm commented Jan 18, 2025

Closed in favour of #1187 it seems we had a duplicity here. Thanks for your contrubition.

@benjagm benjagm closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: DocsHelp component option to hide Edit This on GitHub
4 participants