Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Dark/Light Mode Toggle Doesn't Close Automatically on Mobile #1281

Open
Karan-Palan opened this issue Jan 10, 2025 · 5 comments · May be fixed by #1332
Open

🐛 Bug: Dark/Light Mode Toggle Doesn't Close Automatically on Mobile #1281

Karan-Palan opened this issue Jan 10, 2025 · 5 comments · May be fixed by #1332
Assignees
@Karan-Palan
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@Karan-Palan
Copy link
Contributor

Describe the bug

On the mobile view of the JSON Schema website, when the dark/light mode toggle is opened, it remains open even after the user clicks outside of the toggle or interacts with other elements on the page. This behavior clutters the interface and negatively impacts usability.

Steps To Reproduce

  1. Open the website in mobile view or on a mobile device.
  2. Click on the dark/light mode toggle to open it.
  3. Click anywhere outside the toggle, such as on the main content or a navigation element.
  4. Observe that the toggle remains open and does not close automatically.

Expected Behavior

The dark/light mode toggle should close automatically when:

  1. The user clicks anywhere outside the toggle.
  2. The user interacts with other page elements.

Screenshots

Screencast.from.2025-01-10.16-56-02.webm

Device Information [optional]

- OS:
- Browser:
- version:

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No
@Karan-Palan Karan-Palan added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Jan 10, 2025
@Rudra-Sankha-Sinhamahapatra
Copy link

Rudra-Sankha-Sinhamahapatra commented Jan 19, 2025 •
edited
Loading

@Karan-Palan I tried to fix this issue on PR #1329 can you review it once

@DhairyaMajmudar can you please assign this issue to me , I want to work on this

Rudra-Sankha-Sinhamahapatra added a commit to Rudra-Sankha-Sinhamahapatra/website that referenced this issue Jan 19, 2025
@Rudra-Sankha-Sinhamahapatra
Bug: json-schema-org#1281 fixed, [Dark/Light Mode Toggle Doesn't Clos…
e9663fa 
…e Automatically on Mobile]
Closed
@Karan-Palan
Copy link
Contributor Author

@Rudra-Sankha-Sinhamahapatra yes it does. However I've mentioned in the issue I would work on it , have the changes on a local branch and was waiting for the triage process. Have a read through contributing.md
@DhairyaMajmudar I wouldn't mind accepting this PR , however that would result in redundant work on my part.

@Rudra-Sankha-Sinhamahapatra
Copy link

Rudra-Sankha-Sinhamahapatra commented Jan 19, 2025 •
edited
Loading

@Karan-Palan thanks but I was not aware you were working on it . It was a small mistake from my side .I will take care in future . I would not mind but you can raise a pr and work on it

@Karan-Palan
Copy link
Contributor Author

@Rudra-Sankha-Sinhamahapatra sure. Nice work

@DhairyaMajmudar
Copy link
Member

Hi folks, thank you for the issue proposal. @Rudra-Sankha-Sinhamahapatra we've contributing guidelines for not opening pr w/o issue assignment pls. feel free to look for other unassigned issues.

@Karan-Palan as you are showing your interest in taking this up assigning the issue to you.

@DhairyaMajmudar DhairyaMajmudar added Status: In Progress This issue is being worked on, and has someone assigned. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Triage This is the initial status for an issue that requires triage. labels Jan 19, 2025
@Karan-Palan Karan-Palan linked a pull request Jan 19, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karan-Palan Karan-Palan

Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Milestone
No milestone
3 participants
@Rudra-Sankha-Sinhamahapatra @DhairyaMajmudar @Karan-Palan