-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enhancement: Update on Dockerfile Implementation for Windows Users #1196
Comments
Welcome to the JSON Schema Community. We are so excited you are here! Thanks a lot for reporting your first issue!! 🎉🎉 Please make sure to take a look at our contributors guide if you plan on opening a pull request. |
Thanks for this proposal. Please go ahead with it. |
Node.js are removing corepack as of the next major release, so this will then break again if/when we upgrade major Node.js versions. Maybe by then it will matter less, but figured I'd bring it up. |
Thank you for your feedback on the pull request. I understand that Node.js plans to remove corepack in a future major release, which could lead to compatibility issues once we upgrade to newer Node.js versions. Would you recommend moving forward with nvm or Volta for managing Yarn versions in the Dockerfile, how exactly I can contribute can you please explain in detail ? |
Hi @benjagm, @Relequestual, and @Adi-204, |
heyy @Relequestual can i work on this issue?? |
Thanks for your interest, but the issue is already assigned. |
I encountered an issue while attempting to install Volta in the project. The error message was as follows: main: line 228: /root/.volta/bin/volta: cannot execute: required file not found After researching the issue, I found a potential solution: This solution is working perfectly fine on Windows. Should I proceed with raising a PR for this change, or do we need to explore alternative solutions? Looking forward to your guidance. |
@Adi-204 I'm also getting error while setup the project using docker. I'm currently at linux Ubuntu , if you can solve this problem that will be really great as you are already assigned to this issue |
@AQIB-NAWAB I raise the PR #1204 you can see that I added 1 line dockerfile related to corepack-enable and then run below 3 commands - If you are trying to build using make command I don't have much idea because I am on windows. You can maybe add corepack in dockerfile and then run above 3 commands for now we will soon replace corepack with Volta. |
Please checkout this thread we had a discussion earlier:
Corepack will be still available just it get removed from node js default and corepack will be maintain separately. |
So what is the next plan should we move towards Volta or my earlier PR #1204 can be merged or any changes in PR can you please review and provide feedback. |
okk i'll try to resolve the it |
@Adi-204 can i work on it? |
If you still want to solve raise PR and mention it. They might approve if your solution feels right. |
@DhairyaMajmudar Could you assign me this issue ? as me and @Adi-204 alredy discussed (reference :https://json-schema.slack.com/archives/C8C4UBXDF/p1735456330251609) |
@Relequestual I've tested the changes thoroughly on both Windows and Linux environments and confirmed everything is working as expected without corepack. Please review when you have a chance, and I'm happy to make any adjustments if needed. Thanks! |
Is your feature request related to a problem? Please describe
The current implementation of our Dockerfile, particularly for Windows users.
Key Issues:
Incompatibility with make Command: Currently, Windows users are unable to utilize the make command within the Docker container. This limitation arises from the differences in command-line tools available on Windows compared to Unix-based systems. As a result, any build processes that rely on make will not function as intended on Windows.
Yarn Version Mismatch Error: Additionally, when executing standard Docker commands such as docker build and docker run, users may encounter a yarn version mismatch error. This issue occurs because the version of Yarn installed in the Docker container may differ from the version expected by the application. This discrepancy can lead to build failures and unexpected behavior during runtime.
Describe the solution you'd like
To added the corepack enable command in the Dockerfile. This adjustment ensures that the correct version of Yarn is used consistently across different environments.
Describe alternatives you've considered
No response
Additional context
No response
Are you working on this?
Yes
The text was updated successfully, but these errors were encountered: