Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synapic.js.org #9361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

synapic.js.org #9361

wants to merge 1 commit into from

Conversation

devyigit
Copy link

@devyigit devyigit commented Nov 8, 2024

@MattIPv4 MattIPv4 changed the title Update cnames_active.js synapic.js.org Nov 8, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Please could you explain how your project is related directly to the JavaScript ecosystem/community? Looking at the source, it appears to just be a wrapper around Google Search?

@@ -3137,6 +3137,7 @@ var cnames_active = {
"synth": "lukehorvat.github.io/synth-mood",
"syr": "dmikey.github.io/syr",
"system-monitoring": "miladezzat.github.io/system-monitoring",
"synapic": "https://devyigit.github.io/Synapic-Search-Engine",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the CI error notes, your entry needs to be added in alphabetical order, and without the https://

@MattIPv4 MattIPv4 added invalid awaiting response This PR is waiting for a response from the requester labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response This PR is waiting for a response from the requester invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants